-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for ml inference with cohere rerank model #3398
Tutorial for ml inference with cohere rerank model #3398
Conversation
Hi @brianf-aws, I am thinking we should have a new folder call ml_inference that can host all use cases combing using ml_inference processors. |
And in that folder we can have sub folder for managed service vs opensource so that the blueprint doesn't seem too long. @brianf-aws Could you also take update from main. Seems like the integ test doesn't run. I know for blueprint integ test doesn't matter. I just wanted to check if codecov is activate properly or not. |
41ecf8d
to
6da5b54
Compare
maybe the file path can be docs/tutorials/ml_Inference/rerank/ml_Inference_with_Cohere_Rerank_model.md |
Sorry @mingshl and @dhrubo-os I don't think that would benefit the community that much currently in the directory folder we have 4 documents that mention the
We will make it harder for users to find answers. Consider a community user that wants to rerank documents using our project. they probably will be surprised to find out that they need to look at a directory called ml_inference/rerank. I think perhaps the best case would be to create a file pointing to these tutorials that show how significant the ML inference processor is. |
In the blueprint that use ml_inference processor that was just to demo one of the usage of the model. That's totally fine. but these two can belong to ml_inference folder ./tutorials/rerank/ml_Inference_with_Cohere_Rerank_model.md what do you think? @ylwu-amzn @dhrubo-os |
I see this as a similar issue when we write a long class and then later we start having confusion where to put this class as this serves multiple responsibilities. Take Currently, asymmetric_embedding_model.md tackles both generating asymmetric embeddings and performing semantic search with the ML-Inference processor. To improve clarity and maintainability, I suggest splitting it into two focused tutorials: one for generating embeddings and another for applying them in semantic search. This would make each tutorial easier to follow, reusable in other contexts, and simpler to maintain. |
Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Brian Flores <[email protected]>
6da5b54
to
3986b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! keep this going!!!
* added tutorial for ml inference with cohere rerank model Signed-off-by: Brian Flores <[email protected]> * Refactor placement of tutorials using ML Inference processor Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> (cherry picked from commit 53bc3ec)
* added tutorial for ml inference with cohere rerank model Signed-off-by: Brian Flores <[email protected]> * Refactor placement of tutorials using ML Inference processor Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> (cherry picked from commit 53bc3ec) Co-authored-by: Brian Flores <[email protected]>
Description
Currently there are tutorials that exist using the rerank pipeline. However its possible to do the same operation with the ML_inference processor with the by_field rerank.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.