Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick BWC fix for system prompt and user instructions #3437

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

pyek-bot
Copy link
Contributor

Description

Moves this change to main: #3125
Earlier it was only ported to 2.16 due to conflicts with bedrock versioning. I have fixed this and moving it to main.

Please add backport labels for 2.x, 2.18. It has been backported to 2.17 already: #3364

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@pyek-bot
Copy link
Contributor Author

Failures due to flaky tests:

113 tests completed, 2 failed, 10 skipped
Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel
 - org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound

@b4sjoo b4sjoo merged commit f4d4481 into opensearch-project:main Jan 27, 2025
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 27, 2025
* BWC (rag processor): add version control for newly added request params (#3125) (#3364)

* gradle spotless

Signed-off-by: Pavan Yekbote <[email protected]>

---------

Signed-off-by: Pavan Yekbote <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
(cherry picked from commit f4d4481)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 27, 2025
* BWC (rag processor): add version control for newly added request params (#3125) (#3364)

* gradle spotless

Signed-off-by: Pavan Yekbote <[email protected]>

---------

Signed-off-by: Pavan Yekbote <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
(cherry picked from commit f4d4481)
ylwu-amzn pushed a commit that referenced this pull request Jan 28, 2025
…3441)

* BWC (rag processor): add version control for newly added request params (#3125) (#3364)

* gradle spotless

Signed-off-by: Pavan Yekbote <[email protected]>

---------

Signed-off-by: Pavan Yekbote <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
(cherry picked from commit f4d4481)

Co-authored-by: Pavan Yekbote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants