-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different embedding types of model response #1007
base: main
Are you sure you want to change the base?
Support different embedding types of model response #1007
Conversation
Signed-off-by: zane-neo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
============================================
- Coverage 80.47% 80.36% -0.12%
+ Complexity 1000 998 -2
============================================
Files 78 78
Lines 3411 3412 +1
Branches 578 578
============================================
- Hits 2745 2742 -3
- Misses 425 427 +2
- Partials 241 243 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zane-neo <[email protected]>
Can you provide sample request/response for each of new embedding type? Is the type configurable on the client side (neural search in this case), or model is smart enough to switch between types? Any changes required from user to use new type(s), for instance do they need to recreated model connector and index mapping? |
Sample of different embedding types:
The type is configurable in model side, in the connector specifically. When user wants to switch to a different embedding type, user needs to recreate a new model with different embedding type in the connector, also user should do a reindex to ensure the embeddings are using the new embedding type result, in this case, a new index should created and after the reindex user can specify alias on original index to new one. We don't consider modifying index mapping as we can only add new field in existing index mapping, not able to modify an existing field. |
@zane-neo Plz resolve the conflicting files. The code looks good to me. |
Description
Support different embedding types of model response
Related Issues
#1006
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.