[Backport 2.x] Fixed document source and score field mismatch in sorted hybrid queries #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
martin-gaievski
approved these changes
Jan 3, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1057 +/- ##
============================================
+ Coverage 79.69% 79.78% +0.09%
- Complexity 1104 1106 +2
============================================
Files 87 87
Lines 3802 3805 +3
Branches 649 649
============================================
+ Hits 3030 3036 +6
+ Misses 522 521 -1
+ Partials 250 248 -2 ☔ View full report in Codecov by Sentry. |
vibrantvarun
approved these changes
Jan 3, 2025
…es (#1043) * Fixed mismatch between document source and score fields when sorting is enabled in hybrid query Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 030e3f4) Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
backport/backport-1043-to-2.x
branch
from
6c41ae7 to
6d00a08
Compare
heemin32
pushed a commit
to heemin32/neural-search
that referenced
this pull request
Jan 9, 2025
…es (opensearch-project#1043) (opensearch-project#1057) * Fixed mismatch between document source and score fields when sorting is enabled in hybrid query (cherry picked from commit 030e3f4) Signed-off-by: Martin Gaievski <[email protected]> Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 030e3f4 from #1043