Fix github CI by adding eclipse dependency in formatting.gradle #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
zhichao-aws,
yuye-aws and
minalsha
as code owners
vibrantvarun
commented
Jan 8, 2025
| @@ -20,7 +20,6 @@ | |||
| import static org.opensearch.neuralsearch.util.TestUtils.getModelId; | |||
|
|
|||
| import org.opensearch.index.query.QueryBuilder; | |||
| import org.opensearch.index.query.QueryBuilders; | |||
There was a problem hiding this comment.
This is automatically removed by doing ./gradlew spotlessApply.
|
Reference: diffplug/spotless#1783 (comment) |
heemin32
approved these changes
Jan 8, 2025
|
Could you add change log instead of skipping it under maintenance? |
heemin32
added
the
backport 2.x
|
@heemin32 shall we get 1 review from infra team? |
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
martin-gaievski
approved these changes
Jan 8, 2025
yizheliu-amazon
approved these changes
Jan 8, 2025
Reference diffplug/spotless#1629 |
|
Waiting for 1 review from infra team. Then we will merge it. |
|
cc: @opensearch-project/admin |
rishabh6788
approved these changes
Jan 8, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1079-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ad6546e55550a3d35589bca1d61e032640439af
# Push it to GitHub
git push --set-upstream origin backport/backport-1079-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
martin-gaievski
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Fix github CI by adding eclipse dependency in formatting.gradle Signed-off-by: Varun Jain <[email protected]> * Add changelog Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains changes to fix error
Failed to load eclipse jdt formatterin github CI. Added download eclipse in the formatting.gradle.