Use different package name between restart/rolling bwc tests #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
added
Refactoring
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
heemin32
added
the
backport 2.x
|
@heemin32 It's preferred to keep restart and rolling package consistent. |
|
The code looks good to me. Just need @heemin32 to fix the comment above. |
Thanks. It was a mistake. |
Signed-off-by: Heemin Kim <[email protected]>
| excludeTestsMatching "org.opensearch.neuralsearch.bwc.HybridSearchIT.*" | ||
| excludeTestsMatching "org.opensearch.neuralsearch.bwc.NeuralSparseSearchIT.*" | ||
| excludeTestsMatching "org.opensearch.neuralsearch.bwc.NeuralQueryEnricherProcessorIT.*" | ||
| excludeTestsMatching "org.opensearch.neuralsearch.bwc.restart.MultiModalSearchIT.*" |
There was a problem hiding this comment.
Can you also do the similar change rolling upgrade build.gradle
There was a problem hiding this comment.
There is no such thing for rolling upgrade build.gradle in main branch. I need to make such change when I backport it to 2.x
will-hwang
approved these changes
Jan 15, 2025
junqiu-lei
approved these changes
Jan 15, 2025
martin-gaievski
approved these changes
Jan 15, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit c98b9c2)
heemin32
added a commit
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit c98b9c2)
heemin32
added a commit
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit c98b9c2)
heemin32
added a commit
that referenced
this pull request
Jan 15, 2025
…1107) Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit c98b9c2) Co-authored-by: Heemin Kim <[email protected]>
heemin32
added a commit
to heemin32/neural-search
that referenced
this pull request
Jan 15, 2025
heemin32
added a commit
to heemin32/neural-search
that referenced
this pull request
Jan 15, 2025
…pensearch-project#1096) (opensearch-project#1107)" This reverts commit 1739834. Signed-off-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During bwc test debugging, intelliJ is pointing to wrong code part becase restart/rolling bwc tests are sharing same package name and class name. Separating the package name between the two so that intelliJ debugger can point to correct code part.
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.