Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed flaky integration test for explain in hybrid query #1122

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixed flaky integration test for explain in hybrid query #1122

wants to merge 1 commit into from

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jan 17, 2025 •
edited
Loading

Description

Flaky test results are caused by shared index names. Different tests do change documents in unpredictable manner, that causes test results to be non deterministic, and test level assertions may fail.

Related Issues

#1120

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog integ-test-failure Integration test failures v2.19.0 labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbogan ryanbogan ryanbogan approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 will be requested when the pull request is marked ready for review heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v will be requested when the pull request is marked ready for review navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB will be requested when the pull request is marked ready for review VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin will be requested when the pull request is marked ready for review vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 will be requested when the pull request is marked ready for review jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda will be requested when the pull request is marked ready for review naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei will be requested when the pull request is marked ready for review junqiu-lei is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon will be requested when the pull request is marked ready for review sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse will be requested when the pull request is marked ready for review model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo will be requested when the pull request is marked ready for review zane-neo is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun will be requested when the pull request is marked ready for review vibrantvarun is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws will be requested when the pull request is marked ready for review zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws will be requested when the pull request is marked ready for review yuye-aws is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha will be requested when the pull request is marked ready for review minalsha is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch integ-test-failure Integration test failures skip-changelog v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-gaievski @ryanbogan