Fixing same index name in NeuralQueryIT and HybridQueryIT #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=========================================
Coverage 84.39% 84.39%
Complexity 535 535
=========================================
Files 40 40
Lines 1570 1570
Branches 245 245
=========================================
Hits 1325 1325
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
heemin32
approved these changes
Feb 2, 2024
martin-gaievski
approved these changes
Feb 2, 2024
martin-gaievski
added
the
backport 2.x
martin-gaievski
merged commit c198298
into
opensearch-project:main
154 of 198 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit c198298)
martin-gaievski
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit c198298) Co-authored-by: Varun Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we are fixing the potential flakiness in the integ tests as the index name is same in hybridqueryIT and neuralqueryIT.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.