Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opensearch-learning-to-rank-base to manifest #5245

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rithin-pullela-aws
Copy link
Contributor

Description

Adds the opensearch-learning-to-rank-base plugin to the manifest files.

Following the onboarding steps mentioned here.

PR implementing the build script in LTR: opensearch-project/opensearch-learning-to-rank-base#97

Artifacts published:

artifacts/maven/org/opensearch/opensearch-ltr/2.19.0.0-SNAPSHOT/opensearch-ltr-2.19.0.0-20250117.192241-1.pom
artifacts/maven/org/opensearch/opensearch-ltr/2.19.0.0-SNAPSHOT/opensearch-ltr-2.19.0.0-20250117.192241-1.zip
artifacts/maven/org/opensearch/opensearch-ltr/2.19.0.0-SNAPSHOT/opensearch-ltr-2.19.0.0-20250117.192241-2.pom
artifacts/maven/org/opensearch/opensearch-ltr/2.19.0.0-SNAPSHOT/opensearch-ltr-2.19.0.0-20250117.192241-2.zip
artifacts/plugins/opensearch-ltr-2.19.0.0-SNAPSHOT.zip

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Member

Hi @rithin-pullela-aws

For 3.0.0 looks like the plugin is failing with java compatibility error:

* What went wrong:
Could not open settings generic class cache for settings file '/tmp/tmpv1wmks95/opensearch-learning-to-rank-base/settings.gradle' (/home/runner/.gradle/caches/8.5/scripts/1r7vq1a50dzxpi8s6r0cutotx).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 67

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org./

3.0.0 is using jdk-23.

@dhrubo-os
Copy link

Hi @rithin-pullela-aws

For 3.0.0 looks like the plugin is failing with java compatibility error:

* What went wrong:
Could not open settings generic class cache for settings file '/tmp/tmpv1wmks95/opensearch-learning-to-rank-base/settings.gradle' (/home/runner/.gradle/caches/8.5/scripts/1r7vq1a50dzxpi8s6r0cutotx).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 67

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org./

3.0.0 is using jdk-23.

does this mean all other plugins also needs to be built on JDK 23 too? Referring to ml-commons/flow-framework etc?

@gaiksaya
Copy link
Member

does this mean all other plugins also needs to be built on JDK 23 too? Referring to ml-commons/flow-framework etc?

Yes! jdk-23 is only for 3.0.0. See open issues.
For 2.19, it is still jdk-21.

@gaiksaya
Copy link
Member

Hi @rithin-pullela-aws ,
Can you also add the component to test manifest please?
Thank you!

@rithin-pullela-aws
Copy link
Contributor Author

Hi @rithin-pullela-aws , Can you also add the component to test manifest please? Thank you!

I raised another PR for test workflow: #5246. I was following the steps in the onboarding doc.

@gaiksaya
Copy link
Member

To-do: Add the plugin later to 3.0.0 manifest once the it supports jdk-23.
Thanks!

@gaiksaya gaiksaya merged commit 03d8b93 into opensearch-project:main Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants