Restrict the range of JVMs that need security policy flags set #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstults
force-pushed
the
tests-security-policy
branch
from
a1a3aa9 to
990110c
Compare
jzonthemtn
approved these changes
Sep 12, 2024
|
It seems like there is a threading issue. I can exacerbate the problem by running the tests on a hotspot JVM, and most of the errors happen here in Suppliers.java. What I can't tell yet is whether this is a problem at runtime or if it's just a problem during testing. I'm moving this PR to the draft state until that gets figured out. |
|
I have been getting intermittent failures when building locally and in GitHub Actions. This failure is different than the failed test case in this build but it wouldn't surprise me if it's related. I'd say the build passes every 2 out of 3 times for me. |
- Fix a typo in the security policy file - Reference the security policy file for tests Signed-off-by: Scott Stults <[email protected]>
Restrict the range of JVM versions that need security manager flags Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: jzonthemtn <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: jzonthemtn <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: Scott Stults <[email protected]>
sstults
force-pushed
the
tests-security-policy
branch
from
e0ad7d4 to
1a00e97
Compare
Signed-off-by: Scott Stults <[email protected]>
|
It looks like this issue was addressed in this PR for ES-LTR. After bringing this change over I'm getting reliable builds locally. |
|
Tests passed! Closing. |
sstults
added a commit
to sstults/opensearch-learning-to-rank-base
that referenced
this pull request
Oct 31, 2024
…earch-project#42) Signed-off-by: Scott Stults <[email protected]> Signed-off-by: jzonthemtn <[email protected]> Co-authored-by: Jeff Zemerick <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently test against versions 11, 17, and 21. For version 17 we need to add a policy file, but for version 21 the security manager flags throw an error. This PR restricts the versions that need the flags set to > 11 and < 21.
Issues Resolved
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.