25 npe when featureset not exists #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohannesDaniel <[email protected]>
* IndexFeatureStore.getAndParse returns optional instead of null * IndexFeatureStore.load, IndexFeatureStore.loadSet, IndexFeatureStore.loadModel throw ResourceNotFoundException in case of not existing resource Signed-off-by: JohannesDaniel <[email protected]>
JohannesDaniel
requested review from
gsingers,
macohen and
sstults
as code owners
Signed-off-by: JohannesDaniel <[email protected]>
epugh
approved these changes
Oct 14, 2024
.gitignore
Outdated
| @@ -46,3 +46,4 @@ eclipse-build | |||
| !/.settings/org.eclipse.jdt.ui.prefs | |||
|
|
|||
| bin/* | |||
| .DS_Store | |||
There was a problem hiding this comment.
Can we confirm that other OpenSearch projects have these? I know some projects instead say "put this in your global git ignore file!"
Signed-off-by: JohannesDaniel <[email protected]>
sstults
approved these changes
Oct 15, 2024
sstults
pushed a commit
to sstults/opensearch-learning-to-rank-base
that referenced
this pull request
Oct 31, 2024
Signed-off-by: JohannesDaniel <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handling non existing features, featuresets and models more gracefully by throwing a ResourceNotFoundException + proper message instead of NullPointerException.
Issues Resolved
#25
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.