Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Bump BenchMarkDotNet, xunit, xunit.runner.visualstudio & CSharpier.Core #482

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Dec 18, 2023

Description

Backports recent dependabot PRs to 1.x

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dependabot bot added 4 commits December 18, 2023 16:23
* Bump BenchMarkDotNet from 0.13.10 to 0.13.11

Bumps [BenchMarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.10 to 0.13.11.
- [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases)
- [Commits](dotnet/BenchmarkDotNet@v0.13.10...v0.13.11)

Signed-off-by: Thomas Farr <[email protected]>

---
updated-dependencies:
- dependency-name: BenchMarkDotNet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a3c9659)
…t#477)

* Bump xunit.runner.visualstudio from 2.5.4 to 2.5.5

Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.4 to 2.5.5.
- [Release notes](https://github.com/xunit/visualstudio.xunit/releases)
- [Commits](xunit/visualstudio.xunit@2.5.4...2.5.5)

Signed-off-by: Thomas Farr <[email protected]>

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6af701d)
* Bump CSharpier.Core from 0.26.3 to 0.26.7

Bumps [CSharpier.Core](https://github.com/belav/csharpier) from 0.26.3 to 0.26.7.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.26.3...0.26.7)

Signed-off-by: Thomas Farr <[email protected]>

---
updated-dependencies:
- dependency-name: CSharpier.Core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit ed4fa01)
* Bump xunit from 2.6.2 to 2.6.3

Bumps [xunit](https://github.com/xunit/xunit) from 2.6.2 to 2.6.3.
- [Commits](xunit/xunit@2.6.2...2.6.3)

Signed-off-by: Thomas Farr <[email protected]>

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a9f9eb4)
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we're still releasing a 1.x line of the client?

@dblock dblock merged commit 4b29a58 into opensearch-project:1.x Dec 18, 2023
30 checks passed
@Xtansia Xtansia deleted the backport/dependabot-to-1.x branch December 18, 2023 21:34
@Xtansia
Copy link
Collaborator Author

Xtansia commented Dec 18, 2023

Curious why we're still releasing a 1.x line of the client?

@dblock We only have a 1.x line released so far, there's not been a breaking 2.x release of the client yet

@dblock
Copy link
Member

dblock commented Dec 20, 2023

Any advantage of maintaining a 1.x vs. moving forward with a breaking 2.x?

@Xtansia
Copy link
Collaborator Author

Xtansia commented Jan 7, 2024

@dblock Just hasn't been anything urgently breaking to cut it yet, but wanting to at least finish re-generating the core APIs to capture any potential breakages/renames/deprecations in that before cutting 2.x. Once the JSON serialization work and potential accompanying client refactoring gets done that'll be another major break too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants