Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate namespaces no longer in API spec #270

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

kimpepper
Copy link
Collaborator

Description

Deprecates namespaces no longer in the API spec.

Unfortunately there is no way to deprecate the corresponding methods in the Client as the template doesn't support this.

Issues Resolved

#262

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kimpepper
Copy link
Collaborator Author

The 'Unreleased Opensearch' build fail looks unrelated:

Could not compile settings file '/home/runner/work/opensearch-php/opensearch-php/opensearch/settings.gradle'.
> startup failed:
  General error during semantic analysis: Unsupported class file major version 65

shyim
shyim previously approved these changes Jan 28, 2025
dblock
dblock previously approved these changes Jan 28, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
@dblock
Copy link
Member

dblock commented Jan 28, 2025

The 'Unreleased Opensearch' build fail looks unrelated:

Could not compile settings file '/home/runner/work/opensearch-php/opensearch-php/opensearch/settings.gradle'.
> startup failed:
  General error during semantic analysis: Unsupported class file major version 65

There was a JDK update in opensearch-project/OpenSearch#17144 which was a patch release and shouldn't have caused this. @reta any ideas?

@reta
Copy link
Contributor

reta commented Jan 28, 2025

There was a JDK update in opensearch-project/OpenSearch#17144 which was a patch release and shouldn't have caused this. @reta any ideas?

This is surprising (Gradle for PHP projects) but yeah @dblock , we need to bump the source / target level to JDK-21, I will try to help out shortly Figured out this is a GA workflow, fixing it

Signed-off-by: Kim Pepper <[email protected]>

Update changelog

Signed-off-by: Kim Pepper <[email protected]>
@kimpepper kimpepper force-pushed the deprecate-namespaces branch from 9804aef to 4792a71 Compare January 28, 2025 21:55
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Kim Pepper <[email protected]>
@kimpepper kimpepper dismissed stale reviews from dblock and shyim via 2157520 January 28, 2025 21:57
@dblock dblock merged commit 92b8e45 into opensearch-project:main Jan 30, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants