-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create external connector and local connector #325
Conversation
Ooh! I'll try and test this asap! Thank you 😄 |
Signed-off-by: Vinay Vinod <[email protected]>
bac20d3
to
f5d7895
Compare
Can we please add corresponding tests also? Please check other functions. |
Codecov Report
@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 91.36% 91.19% -0.17%
==========================================
Files 38 38
Lines 4237 4249 +12
==========================================
+ Hits 3871 3875 +4
- Misses 366 374 +8
|
lint is failing. Could you please check. You should be able to run |
@Vinay-Vinod are you working on this issue? |
…@gmail.com> Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
…into vinayvinod
Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
Are you having any issues with git? Please feel free to ask question in the slack channel if you are blocked. In addition, we need this PR to be done asap. Could you please give any ETA? Thanks. |
Was having issue running the linter, but was able to fix |
Merge conflict. |
Any ETA to wrap up this PR? Turns out we need this support in py-ml asap. Let me know if you are available to expedite this development. Otherwise, I will try to assign this someone else. Thanks. |
I dont know why I keep failing some of the linting tests, but I'm pretty sure my code is right. You can assign the issue to someone else since this is needed ASAP @dhrubo-os |
@rawwar could you please take over this PR then? |
@Vinay-Vinod can we close this PR in respect of this PR? |
Yes of course, go ahead @dhrubo-os |
Closelose this PR in respect of PR |
Description
Adds support for external connector and local connector. Supports endpoints for:
connection.ml_connector.create()
connection.ml_connector.delete()
connection.ml_connector.list()
connection.ml_connector.search()
Issues Resolved
[List any issues this PR will resolve]
Solves [FEATURE] Support for ML Extensibility #284
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.