Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch AL2 to AL2023 agent and DockerHub to ECR images in ml-models.JenkinsFile #377

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

peterzhuamazon
Copy link
Member

Description

Switch AL2 to AL2023 agent and DockerHub to ECR images

Issues Resolved

Closes #376

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added enhancement New feature or request backport 1.x labels Feb 21, 2024
@peterzhuamazon peterzhuamazon self-assigned this Feb 21, 2024
@peterzhuamazon peterzhuamazon changed the title Switch AL2 to AL2023 agent and DockerHub to ECR images Switch AL2 to AL2023 agent and DockerHub to ECR images in ml-models.JenkinsFile Feb 21, 2024
Signed-off-by: Peter Zhu <[email protected]>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0b1bcf) 91.53% compared to head (2c20a49) 91.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          42       42           
  Lines        4395     4395           
=======================================
  Hits         4023     4023           
  Misses        372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os merged commit e5001df into opensearch-project:main Feb 21, 2024
14 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-377-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e5001df265c4814eb0ff94b6f49390ebe9cabc9b
# Push it to GitHub
git push --set-upstream origin backport/backport-377-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-377-to-1.x.

@peterzhuamazon peterzhuamazon deleted the switch-al2023-agent branch February 21, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update Jenkins Agent and Docker Image Registry following opensearch-build standards
3 participants