-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sort_index parameter to DataFrame.to_pandas function #392
added sort_index parameter to DataFrame.to_pandas function #392
Conversation
Signed-off-by: Arnav-Gr0ver <[email protected]>
I think it should be query_compiler.index.os_index_field |
Signed-off-by: Arnav-Gr0ver <[email protected]>
You're right @cbeaujoin-stellar , didn't notice that it was an object method |
@Arnav-Gr0ver could you please take a look at the failures? Thanks |
Signed-off-by: Arnav-Gr0ver <[email protected]>
Integ tests are failing:
Could you please check? Thanks. |
I'll take a look! |
Signed-off-by: Arnav-Gr0ver <[email protected]>
@Arnav-Gr0ver integ tests are still failing. Do you know how to run integ test in your end before pushing a change? |
From the developer guide "nox -s test", the installed version of python on my machine is 3.11 so I'll setup 3.8 - 3.10 and rerun the command so I can run integ tests without pushing. |
Description
Resolves DataFrame.to_pandas duplication bug when an os_index_field is set, following expected behavior
Issues Resolved
#382
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.