Add MultiTerms Aggregation #663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mckirk <[email protected]>
Signed-off-by: mckirk <[email protected]>
mckirk
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 72.14% 72.15%
=======================================
Files 89 89
Lines 7945 7947 +2
=======================================
+ Hits 5732 5734 +2
Misses 2213 2213 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mckirk <[email protected]>
saimedhi
reviewed
Feb 1, 2024
Signed-off-by: mckirk <[email protected]>
|
How does one use it? Maybe add to guides/ ? |
saimedhi
approved these changes
Feb 1, 2024
|
Hello @mckirk, could you please implement the requested changes? Thank you! |
|
Rebased in #797. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes it possible to use the
multi_termsbucket aggregation, using the syntaxIt is similar to PR#1543 from the
elasticsearch-dsl-pyrepo.I hope that is okay, since that project is also licensed under Apache 2.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.