Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Add separate metric for cluster manager service events and metrics #594

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 951df93 from #579

)

* Add separate metric for cluster manager service events and metrics

* Fix build error related to missing import

Signed-off-by: Khushboo Rajput <[email protected]>

* Fix test build failure

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Khushboo Rajput <[email protected]>
(cherry picked from commit 951df93)
@khushbr
Copy link
Collaborator

khushbr commented Nov 14, 2023

Addresses build failure in #586

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d907f19) 68.42% compared to head (942364c) 68.48%.

❗ Current head 942364c differs from pull request most recent head bfa98c7. Consider uploading reports for the commit bfa98c7 to get more accurate results

Files Patch % Lines
.../collectors/ClusterManagerServiceEventMetrics.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #594      +/-   ##
============================================
+ Coverage     68.42%   68.48%   +0.05%     
- Complexity      364      365       +1     
============================================
  Files            44       44              
  Lines          2480     2481       +1     
  Branches        172      172              
============================================
+ Hits           1697     1699       +2     
+ Misses          679      678       -1     
  Partials        104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbcd90 sbcd90 merged commit ab18594 into 2.11 Nov 14, 2023
6 checks passed
@github-actions github-actions bot deleted the backport/backport-579-to-2.11 branch November 14, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants