-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove records with grouping #26
Merged
deshsidd
merged 1 commit into
opensearch-project:main
from
ansjcy:remove-records-with-grouping
Nov 11, 2024
Merged
remove records with grouping #26
deshsidd
merged 1 commit into
opensearch-project:main
from
ansjcy:remove-records-with-grouping
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <[email protected]>
Note: there will be conflicts with https://github.com/opensearch-project/query-insights-dashboards/pull/21/files |
deshsidd
approved these changes
Nov 7, 2024
deshsidd
added a commit
that referenced
this pull request
Nov 15, 2024
This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
added a commit
that referenced
this pull request
Nov 15, 2024
This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
added a commit
that referenced
this pull request
Jan 14, 2025
This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]>
ansjcy
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "remove records with grouping (#26)" This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]> * Query grouping dashboard changes and extensive tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix tests and linting Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments and update tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Update cypress tests, hashcode to id, refactoring Signed-off-by: Siddhant Deshmukh <[email protected]> * Lint Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]>
ansjcy
pushed a commit
to ansjcy/query-insights-dashboards
that referenced
this pull request
Jan 16, 2025
…ect#33) * Revert "remove records with grouping (opensearch-project#26)" This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]> * Query grouping dashboard changes and extensive tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix tests and linting Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments and update tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Update cypress tests, hashcode to id, refactoring Signed-off-by: Siddhant Deshmukh <[email protected]> * Lint Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
added a commit
that referenced
this pull request
Jan 16, 2025
* Revert "remove records with grouping (#26)" This reverts commit 9efdbaf. * Query grouping dashboard changes and extensive tests * Fix tests and linting * Address review comments * Address review comments and update tests * Update cypress tests, hashcode to id, refactoring * Lint --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove records with grouping enabled
Testing
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.