Fix Bug: Include Transient Settings in Fetch Logic #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishoreKicha14
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
|
Can you add more details to the description and link the bug that you are fixing please? @KishoreKicha14 |
|
Please don't include changes from other PRs in this PR #40 |
|
Also please attach screenshot/videos to show the fix is working. |
KishoreKicha14
changed the title
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
force-pushed
the
Fix_transient
branch
from
671832a to
739f6a7
Compare
|
closing based on : #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fetching settings via the code in the following file:
TopNQueries.tsx - Line 185, the logic seems to only account for persistent settings.
Bug Link: #29
Issue: Transient settings are ignored.
Concern: Should transient settings be included, or is it mandatory for these settings to be marked as persistent?
Issues Resolved
What Changed: Transient settings accounted in addition to persistent settings, unless explicitly intended otherwise.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.