-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Query Insights Dashboards style integration - Configuration Page #68
Fix: Query Insights Dashboards style integration - Configuration Page #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to include similar changes in for configuration page: #53
I'll take care of it.
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
43c9a57
to
97c5ffd
Compare
Could you update the screenshot in the PR to reflect the latest change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. merging it now.
…#68) * Fix QI-Styling-Configuration Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Fix QI-Styling-Configuration-lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 0eb3b73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#68) * Fix QI-Styling-Configuration Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Fix QI-Styling-Configuration-lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 0eb3b73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#68) (#108) * Fix QI-Styling-Configuration * Fix QI-Styling-Configuration-lint --------- (cherry picked from commit 0eb3b73) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
…#68) (#110) * Fix QI-Styling-Configuration * Fix QI-Styling-Configuration-lint --------- (cherry picked from commit 0eb3b73) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
Description
This change introduces improvements to the configuration page by enhancing the UI and aligning it with the latest design guidelines. The main updates include:
EuiFlexGroup
,EuiPanel
, and other components to structure the content in a modular, maintainable manner.Changed Made
EuiDescriptionList Integration:
Compressed Layout:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Looks Now:
![Configuration](https://private-user-images.githubusercontent.com/30365405/411746271-77797f2e-4a12-4313-ac62-13c51d7168c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjEwNzIsIm5iZiI6MTczOTYyMDc3MiwicGF0aCI6Ii8zMDM2NTQwNS80MTE3NDYyNzEtNzc3OTdmMmUtNGExMi00MzEzLWFjNjItMTNjNTFkNzE2OGMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDExNTkzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyNjJmYWE0MzY4OGJlNzMxZmFhNWU0NjYzN2VlOWVhZWQzOWE3MDVhYzVjMGExOGY0MjBkMTE4MTdkZjIzYjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KPHl6C3wtIiCANxxXs97FNMMRmPcYaM0NWCHEsZE2tw)