Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Query Insights Dashboards style integration - Configuration Page #68

Conversation

KishoreKicha14
Copy link
Contributor

@KishoreKicha14 KishoreKicha14 commented Jan 24, 2025

Description

This change introduces improvements to the configuration page by enhancing the UI and aligning it with the latest design guidelines. The main updates include:

  • Ensuring the use of semantic header tags for accessibility.
  • Adjusting text sizes for regular and heading text to match the type ramp specifications.
  • Implementing consistent padding and layout for a clean and responsive design.
  • Using EuiFlexGroup, EuiPanel, and other components to structure the content in a modular, maintainable manner.

Changed Made

EuiDescriptionList Integration:

  • Used to display configuration settings with their descriptions.
  • Helps maintain a clear and concise UI.
  • Configurations like "Enabled" and their respective descriptions (e.g., "Enable/disable top N query monitoring") are displayed in a compact and organized manner.
    Compressed Layout:
  • Utilized the compressed={true} prop to minimize the vertical space between items, ensuring the UI stays compact and avoids unnecessary scrolling.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks Now:
Configuration

Copy link
Member

@ansjcy ansjcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to include similar changes in for configuration page: #53
I'll take care of it.

public/pages/Configuration/Configuration.tsx Outdated Show resolved Hide resolved
Kishore Kumaar Natarajan added 2 commits January 29, 2025 15:08
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
@KishoreKicha14 KishoreKicha14 force-pushed the Query-Insights-Dashboards-Trineo-style-integration-Configuration branch from 43c9a57 to 97c5ffd Compare January 30, 2025 20:05
@ansjcy
Copy link
Member

ansjcy commented Feb 10, 2025

Could you update the screenshot in the PR to reflect the latest change?

@KishoreKicha14 KishoreKicha14 changed the title Fix: Query Insights Dashboards Trineo style integration - Configuration Page Fix: Query Insights Dashboards style integration - Configuration Page Feb 10, 2025
Copy link
Member

@ansjcy ansjcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. merging it now.

@ansjcy ansjcy merged commit 0eb3b73 into opensearch-project:main Feb 10, 2025
16 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 14, 2025
…#68)

* Fix QI-Styling-Configuration

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>

* Fix QI-Styling-Configuration-lint

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>

---------

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
(cherry picked from commit 0eb3b73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 14, 2025
…#68)

* Fix QI-Styling-Configuration

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>

* Fix QI-Styling-Configuration-lint

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>

---------

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
(cherry picked from commit 0eb3b73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Feb 14, 2025
…#68) (#108)

* Fix QI-Styling-Configuration



* Fix QI-Styling-Configuration-lint



---------



(cherry picked from commit 0eb3b73)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy pushed a commit that referenced this pull request Feb 14, 2025
…#68) (#110)

* Fix QI-Styling-Configuration



* Fix QI-Styling-Configuration-lint



---------



(cherry picked from commit 0eb3b73)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants