Migrate from Joda-Time to java.time API #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Zane <[email protected]>
dzane17
requested review from
ansjcy,
jainankitk and
deshsidd
as code owners
ansjcy
approved these changes
Jan 3, 2025
src/main/java/org/opensearch/plugin/insights/core/reader/LocalIndexReader.java
Show resolved
Hide resolved
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: David Zane <[email protected]> (cherry picked from commit f570d9f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
Jan 3, 2025
(cherry picked from commit f570d9f) Signed-off-by: David Zane <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the codebase from Joda-Time to the
java.timeAPI to align with Java's standard library and ensure future compatibility, as Joda-Time is no longer maintained. It replaces Joda-Time classes likeDateTimeandDateTimeZonewithjava.timeequivalents (ZonedDateTime,ZoneOffset) and updates parsing, formatting, and date-time operations. This change improves maintainability and uses the modern, supportedjava.timeAPI.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.