Query Details page crash when refreshing - Model #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
deshsidd
reviewed
Jan 16, 2025
| * UUID | ||
| */ | ||
| private final String id; | ||
| public static final String ID = "id"; |
There was a problem hiding this comment.
We already have ID in this file : https://github.com/opensearch-project/query-insights/pull/189/files#diff-4f0f5f144ba2dc04564479bc043edac327cfdbb4d2532aecb52092c8882b308bR102
Not sure why this is needed.
There was a problem hiding this comment.
based on our discussion will rename the older ID to query_group_id
|
Based on my understanding we do not need this change - I have already implemented most of this in my previous PR. cc @ansjcy @KishoreKicha14 |
|
@KishoreKicha14 Next time please try to run code hygiene and tests locally before creating a PR? Thanks |
|
Closing in favor of : #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made some to the model by adding ID field
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.