Add fetch top queries by id API #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhant Deshmukh <[email protected]>
ansjcy
approved these changes
Jan 23, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 210ce5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jan 23, 2025
(cherry picked from commit 210ce5d) Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all the backend changes required to add the fetch top queries by id API.
This change is a prerequisite to the change on the UI to make sure we include the
to,fromandidin the url for the query/group details page and make an API call to fetch the query/group details rather than propagating the information from the Top N queries page.Change comprises of the following:
idas an optional param to the top queries APITesting:
Tested on localhost.
Get query/group by id:
Get query/group by id:
Get queries/groups without id with time range:
Get queries/groups without id and without time range:
Issues Resolved
closes: #159
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.