Always collect available metrics in top queries service #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
always-collect-metrics
branch
from
5d963c8 to
8fd8706
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit a52586a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jan 24, 2025
(cherry picked from commit a52586a) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we are not collecting metrics that are not enabled for top n queries, which causes certain measurements fields missing in local index sometimes. This is not a consistent behavior, idealy, when user configure "enabling/disabling top n queries by cpu", we should really just adding/removing the logic to push the records into the cpu metric heap, but whether the the top n queries are configured or not, we should always collect the metric.
Issues Resolved
#204
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.