Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tenant Tab behavior when Local Cluster is disabled #1933

Closed
derek-ho opened this issue May 2, 2024 · 5 comments · Fixed by #1937
Closed

[BUG] Tenant Tab behavior when Local Cluster is disabled #1933

derek-ho opened this issue May 2, 2024 · 5 comments · Fixed by #1937
Assignees
Labels
bug Something isn't working triaged

Comments

@derek-ho
Copy link
Collaborator

derek-ho commented May 2, 2024

What is the bug?
When local cluster is disabled, the "tenant" tab is still pulling info from the local cluster - this is because this tab is locked to the local cluster even when there are external clusters due to dashboards confusion - this needs to be addressed - either show empty data on this tab or remove the tab altogether when local cluster is disabled.

@derek-ho derek-ho added bug Something isn't working untriaged labels May 2, 2024
@derek-ho
Copy link
Collaborator Author

derek-ho commented May 2, 2024

@kgcreative can you add any comments here on what is the expected behavior here?

@kgcreative
Copy link
Member

This is not a bug and is as intended. The local cluster being disabled means we don't want to use the indexes on the local cluster for data analysis, but the local cluster is the compute for OSD instead. We should probably omit the data source picker for multitenancy in general, since it's OSD multi tenancy, and not backend multitenancy

@derek-ho
Copy link
Collaborator Author

derek-ho commented May 3, 2024

This is not a bug and is as intended. The local cluster being disabled means we don't want to use the indexes on the local cluster for data analysis, but the local cluster is the compute for OSD instead. We should probably omit the data source picker for multitenancy in general, since it's OSD multi tenancy, and not backend multitenancy

Sure we can remove the picker from this tab overall. I get what you are saying, but I still think it is an edge case - when local cluster is hidden, the picker shows like this - an empty state, but it is still pulling data from the local cluster. @kgcreative so final call is to just remove the picker from this tab all together?
Screenshot 2024-04-30 at 12 43 14 PM

@derek-ho derek-ho self-assigned this May 3, 2024
@stephen-crawford
Copy link
Contributor

[Triage] Hi @derek-ho thanks for filing this issue. It looks like you opened a PR to resolve this and are working with Kevin to take the best approach for handling things. Going to marked as triaged.

@kgcreative
Copy link
Member

Ideally we should show a read-only single-select state showing the local cluster (for consistency sake), rather than removing local cluster. I think we need to show local cluster in security regardless of whether the local cluster is disabled, since that's how that will allow customers to do things like setup auth, create users, roles, etc for opensearch dashboards when security is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants