Revert "Remove MDS selector for tenancy tab" #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d0f262.
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
==========================================
- Coverage 69.94% 69.91% -0.03%
==========================================
Files 97 97
Lines 2505 2506 +1
Branches 343 336 -7
==========================================
Hits 1752 1752
- Misses 672 673 +1
Partials 81 81 ☔ View full report in Codecov by Sentry. |
stephen-crawford
approved these changes
May 9, 2024
|
Why are we reverting this? |
Added context in the description |
DarshitChanpura
approved these changes
May 13, 2024
|
Thank you for updating the description @derek-ho ! |
cwperks
approved these changes
May 13, 2024
|
@derek-ho Can you check code-cov failures once to determine if any tests are necessary? |
I think it's fine, the test change also works and its a one-liner. Merging as is. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 14, 2024
This reverts commit 9d0f262. Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 37c2695)
derek-ho
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 9d0f262. Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 37c2695) Co-authored-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1937
Edit: Adding more context here. The reason for this revert is @kgcreative's comment here: #1933 (comment). Ideally, this tab should have the picker locked to the local cluster to maintain the same look across the plugin. Core doesn't have any plan to implement this, so we will add this back, and call it a user mis-configuration if that decide to hide the local cluster. Since security plugin is more of an admin view, when they visit they should have local cluster enabled.