Remove special handling for do_not_fail_on_forbidden on cluster actions #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibix
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
nibix
force-pushed
the
priv-eval-cluster-vs-index-actions
branch
from
98dd626 to
7cd04a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4486 +/- ##
==========================================
- Coverage 65.27% 65.24% -0.03%
==========================================
Files 313 313
Lines 22058 22045 -13
Branches 3563 3559 -4
==========================================
- Hits 14398 14384 -14
+ Misses 5889 5887 -2
- Partials 1771 1774 +3
|
nibix
force-pushed
the
priv-eval-cluster-vs-index-actions
branch
2 times, most recently
from
8aaf278 to
09bb8c5
Compare
This special handling does not provide any benefits - rather it just causes some inconsistent behavior. Fixes opensearch-project#4485 Signed-off-by: Nils Bandener <[email protected]>
nibix
force-pushed
the
priv-eval-cluster-vs-index-actions
branch
from
09bb8c5 to
fba55ac
Compare
|
To avoid any confusion: Yes, this is already complete. The only code-change not related to tests is the removal of the |
RyanL1997
approved these changes
Jun 24, 2024
willyborankin
approved these changes
Jun 25, 2024
willyborankin
merged commit f37399e
into
opensearch-project:main
41 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
…ns (#4486) Signed-off-by: Nils Bandener <[email protected]> (cherry picked from commit f37399e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special handling for
do_not_fail_on_forbiddenon cluster actions does not provide any benefits - rather it just causes some inconsistent behavior. See #4485 for the details.This is part of the work done for #3870
Description
do_not_fail_on_forbiddenset totrueand tofalsewill need the same set of privileges for multi actions and scroll actions. The need to specifyindices:data/read/mget,indices:data/read/msearch,indices:data/read/mtv,indices:data/read/scrollandindices:data/read/search/template/renderas index permissions in the roles config will go away.Issues Resolved
Testing
DoNotFailOnForbiddenTestshave been adapted.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.