-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup SystemIndexTests with RunAsSubjectClient #5027
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5027 +/- ##
==========================================
- Coverage 71.50% 71.49% -0.01%
==========================================
Files 336 336
Lines 22625 22625
Branches 3598 3598
==========================================
- Hits 16178 16176 -2
- Misses 4648 4653 +5
+ Partials 1799 1796 -3 |
Signed-off-by: Craig Perkins <[email protected]>
5e5339d
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-5027-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5e5339d39b80297ca2e9411854fbca4440d5d51c
# Push it to GitHub
git push --set-upstream origin backport/backport-5027-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Backport for this change will be included in #5028 |
Description
This PR is a follow-up to #4896 that borrows the RunAsSubjectClient concept from opensearch-project/OpenSearch#16976 and shows how an IdentityAwarePlugin can use the pluginSubject that its been assigned to initialize a client wrapper that can be used for SystemIndexAccess.
This PR only contains test changes.
Test refactor
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.