Adds a quick fix to flaky test and corrects run-time error #5029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
cwperks,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
|
@DarshitChanpura Can you fix the CI failures? |
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
flaky-test-quick-fix
branch
2 times, most recently
from
5885d9e to
f19a0a7
Compare
cwperks
approved these changes
Jan 17, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 36f67f0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky test: SafeSerializationUtilsTests#testCaching and resolves a gradle build error caused by missing syntax.
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documented- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR- [ ] API changes companion pull request createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.