[Backport 2.x] Ensure that plugin can update on system index when utilizing pluginSubject.runAs (#5055) #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject.runAs (opensearch-project#5055) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ec99e7e) Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
derek-ho
approved these changes
Jan 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5063 +/- ##
==========================================
+ Coverage 68.08% 68.15% +0.06%
==========================================
Files 347 347
Lines 24548 24550 +2
Branches 4069 4069
==========================================
+ Hits 16713 16731 +18
+ Misses 5913 5895 -18
- Partials 1922 1924 +2
|
RyanL1997
approved these changes
Jan 27, 2025
shikharj05
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ec99e7e)
Backport #5055 to 2.x