Remove deprecated route and endpoint #5066
Conversation
willyborankin
force-pushed
the
remove-opendistro-path
branch
from
9ee8334 to
6d4cfb1
Compare
|
@willyborankin To fully complete removing Something similar to opensearch-project/security-dashboards-plugin#895 which was reverted due to not having a backend PR merged in simultaneously. There were 2 backend PRs after the break: |
|
Kindly check - #5031 (comment) |
willyborankin
force-pushed
the
remove-opendistro-path
branch
4 times, most recently
from
724cf6b to
650f7d4
Compare
willyborankin
force-pushed
the
remove-opendistro-path
branch
from
650f7d4 to
b403d43
Compare
willyborankin
changed the title
willyborankin
force-pushed
the
remove-opendistro-path
branch
2 times, most recently
from
02ad520 to
6025216
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
==========================================
- Coverage 71.47% 71.45% -0.03%
==========================================
Files 336 336
Lines 22625 22623 -2
Branches 3601 3601
==========================================
- Hits 16171 16165 -6
- Misses 4657 4660 +3
- Partials 1797 1798 +1
|
willyborankin
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997 and
reta
as code owners
| @@ -221,9 +221,9 @@ private SingleLogoutService findSingleLogoutService(IDPSSODescriptor idpSsoDescr | |||
| private String buildAssertionConsumerEndpoint(String dashboardsRoot) { | |||
|
|
|||
| if (dashboardsRoot.endsWith("/")) { | |||
| return dashboardsRoot + "_opendistro/_security/saml/acs"; | |||
| return dashboardsRoot + "_security/saml/acs"; | |||
There was a problem hiding this comment.
| return dashboardsRoot + "_security/saml/acs"; | |
| return dashboardsRoot + "_plugins/_security/saml/acs"; |
This instance and the one below both need to start with _plugins/. I think I saw another instance above as well. Can you make sure the prefix still exists, but _opendistro is replaced with _plugins?
willyborankin
force-pushed
the
remove-opendistro-path
branch
from
6025216 to
7f85017
Compare
Removed: - `/_opendistro` route - `/_opendistro/kibanainfo` endpoint Signed-off-by: Andrey Pleskach <[email protected]>
| @@ -36,23 +36,23 @@ | |||
| * SuperAdmin certificate for the default superuser is stored as a kirk.pem file in config folder of OpenSearch | |||
| * <p> | |||
| * Example calling the PUT API as SuperAdmin using curl (if http basic auth is on): | |||
| * curl -v --cacert path_to_config/root-ca.pem --cert path_to_config/kirk.pem --key path_to_config/kirk-key.pem -XPUT https://localhost:9200/_opendistro/_security/api/whitelist -H "Content-Type: application/json" -d’ | |||
| * curl -v --cacert path_to_config/root-ca.pem --cert path_to_config/kirk.pem --key path_to_config/kirk-key.pem -XPUT https://localhost:9200/_security/api/whitelist -H "Content-Type: application/json" -d’ | |||
There was a problem hiding this comment.
There's other instances in this file too. I see a few others across the files covered in this PR that need to be updated.
There was a problem hiding this comment.
I plan to remove the White List API in a follow-up PR, as the Allow List now fully replaces it.
There was a problem hiding this comment.
Got it. Do we need to introduce another API like the migrate API to handle cases where a cluster may still be referencing whitelist.yml?
Description
Removed:
/_opendistroroute/_opendistro/kibanainfoendpointTesting
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.