-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add datasource timesync #733
Open
mdhsl
wants to merge
5
commits into
dev
Choose a base branch
from
cannot_add_datasource_timesync
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into TimeSeries handler before calling handleData() - Remove the Time BC after disconnecting the handler - Sometimes, some WebWorker & BC latency are causing actions and data come after => check if replay Function of SweApi handler is defined before calling it - Re-init the TimeSeries dataSource with existing timeSync topic (which means a dataSynchronizer has been previously set to it) - Improve Time intersection of the setTimeRange dataSource function - update addDataSource method to correctly set min/max TimeRange after adding/deleting a given dataSource. Fire an event when the dataSynchronizer range time has been updated - add function to reset times when there is no dataSource anymore into DataSynchronizer - Fix issue into dataSynchronizer worker while deleting a dataSource => check if the id of a given dataSource is still in global dataSource map before posting web worker message - Fix issue into DataSynchronizer algo replay => check if the id of a given dataSource is still in global dataSource map before pushing data into algo - Check into DataSynchronizer algo replay if its time range intersect the current time range of the synchronizer, otherwise, it is skipped by default - Fix issue into DataSynchronizer algo replay if there is no more DataSources, we are not start algo anymore if totalDatasources === 0 - Fix naming of RangeSliderView and add timeRange to specify the range of the slider and use start/end time to specify the range of the handles - Add properties to specify default startValue of the RangeSliderView. This is usefull if we want to start at a specific time of the timeRange - The setTime() function of RangeSliderView now updates the time range as well as currentTime - Add destroy() function to the RangeSliderView to close the BC and destroy the slider by calling slider.destroy() - Replace HTML code of slider by Vue RangeSlider component into TimeController.replay - Display alway the MASTER TIME into TimeController except if we have no more dataSource - use onTimeChanged of the DataSynchronizer to update RangeSlider and display start/end times - fix naming: use ISO date for *time and timestamp for *timestamp into TimeController - Set the last current time of TimeController.replay while switching between realTime & Replay - Add RangeSlider Vue Component
… ControlTime & RangeSlider components - Improve & Update TimeController realtime component by adding separated RangeSlider component - Add methods to destroy rangeSlider correctly while leaving Realtime TimeController (compliant Vue 2 & Vue 3) - Add methods to destroy rangeSlider correctly while leaving Replay TimeController (compliant Vue 2 & Vue 3) - Add RangeSlider Realtime Vue component
…urce and MASTER_TIME for a DataSynchronizer
…pute min/max time when adding a datasource; fix issue while setting current timestamp & fix onTimeChanged - DataSynchronizer: add 2 new events: onRemovedDataSource() & onAddedDataSource - DataSynchronizer: do not connect in replay mode if there is no dataSource attached to it - DataSynchronizer & worker : fix IsConnected() function - DataSynchronizer: fix issue while setting new TimeRange and there was no dataSource - DataSynchronizer Algo RT & Replay: compute tsRun into the loop - DataSynchronizer Algo Replay: check after each loop if the interval has been clear; test if a dataSource has been skipped into the computeNextData and set to skip=false if the dataSource is now is the correct time range; fix issue while a dataSource is removed but still on the final loop before sending the data; reset tsRun while calling reset(); add removeDataSource to re-compute min/max and call reset() if necessary - RangeSliderView: disable/enable if there is no more datasource - TimeController RT: reset correctly the startTimestamp if a dataSource is added with a min < Sum of all current min (idem for max); fix missing await on Promise while setting new TimeRange; setting play/pause icon after reading dataSynchronizer new status and check the new connected status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.