MGMT-14922: Allow 'patch' in custom manifest file name #2252
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ammont82: This pull request references MGMT-14922 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ammont82
added
OCM
and removed
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ammont82
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
size/XS
| return new RegExp(FILENAME_REGEX).test(fileName || ''); | ||
| return ( | ||
| new RegExp(FILENAME_REGEX).test(fileName || '') || | ||
| fileName.indexOf('.yaml.patch') > -1 || |
There was a problem hiding this comment.
I don't think this is correct, because FILENAME_REGEX is ensuring that the fileName does not contain a slash. If one of the ORs becomes true, it could be for a fileName containing a slash.
I think we should use a second regular expression that contains the same part about the slash, and additionally it validates the yaml.patch or yml.patch part.
Also, note that FILENAME_REGEX is already a regular expression, so doing new RegExp(regexp) is unnecessary and less eficient.
There was a problem hiding this comment.
I've marked as draft this PR because BE is not allowing us to put .yaml.patch or .yml.patch in the name. I'm waiting for BE response to see how we can align the regexp.
jkilzi
force-pushed
the
master
branch
7 times, most recently
from
745700c to
203646c
Compare
|
I've closed the PR because we need some BE changes for this. I'll create a new one when BE have a solution. |
openshift-ci-robot
added
the
jira/valid-reference
|
@ammont82: This pull request references MGMT-14922 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to https://issues.redhat.com/browse/MGMT-14922