Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-11178: Create subtasks to track preflight checks #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Jan 10, 2025

These changes will take imageType, payloadName, and imageVersion to determine what subtasks should be added to the Jira that is automatically created. It will then create the subtasks depending on the type of image request.

The client side needs to pass in the parameters and hence openshift-eng/art-dashboard-ui#142 needs to merge first.

This Jira is what this code produced (for the payload case).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025

@DennisPeriquet: This pull request references ART-11178 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

These changes will take imageType, payloadName, and imageVersion to determine what subtasks should be added to the Jira that is automatically created. It will then create the subtasks depending on the type of image request.

The client side needs to pass in the parameters so this is has to be WIP for now.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joepvd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025

@DennisPeriquet: This pull request references ART-11178 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

These changes will take imageType, payloadName, and imageVersion to determine what subtasks should be added to the Jira that is automatically created. It will then create the subtasks depending on the type of image request.

The client side needs to pass in the parameters and hence openshift-eng/art-dashboard-ui#142 needs to merge first.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet DennisPeriquet force-pushed the art-11178-subtasks1 branch 2 times, most recently from 30a6d78 to e1bcd11 Compare January 15, 2025 17:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@DennisPeriquet: This pull request references ART-11178 which is a valid jira issue.

In response to this:

These changes will take imageType, payloadName, and imageVersion to determine what subtasks should be added to the Jira that is automatically created. It will then create the subtasks depending on the type of image request.

The client side needs to pass in the parameters and hence openshift-eng/art-dashboard-ui#142 needs to merge first.

This Jira is what this code produced (for the payload case).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet DennisPeriquet changed the title ART-11178: WIP, Create subtasks to track preflight checks ART-11178: Create subtasks to track preflight checks Jan 15, 2025
@DennisPeriquet
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants