Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[konflux] set a finalizer so that PLR perists #1019

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashwindasr
Copy link
Contributor

Sometimes, during mass builds, a PipelineRun (PLR) might finish early but before our automation comes to check on it, it would have been pruned by konflux. Setting a finalizer will let us work around that.

But in order for us to be good citizens and don't put pressure on the etcd database by keeping a lot of PLRs around, we have to make sure to clean up after ourselves. Hence in addition to this, we would need a periodic job to remove our PLRs if the condition .metadata.deletionTimestamp != null and .metadata.deletionTimestamp - now() > 12h is satisfied.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 10, 2024
@ashwindasr ashwindasr force-pushed the finalizer-feature branch 2 times, most recently from 9166d05 to 3b88694 Compare October 10, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants