Exclude images not enabled in Konflux from the scan report #1176
Conversation
|
@locriandev: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -640,9 +640,21 @@ def add_image_meta_change(self, meta: ImageMetadata, rebuild_hint: RebuildHint): | |||
| self.add_assessment_reason(descendant_meta, RebuildHint(RebuildHintCode.ANCESTOR_CHANGING, | |||
| f'Ancestor {meta.distgit_key} is changing')) | |||
|
|
|||
| def is_image_enabled(self, image_name: str) -> bool: | |||
| image_meta = self.runtime.image_map[image_name] | |||
There was a problem hiding this comment.
Would like to add a check to return False if the image_name is not in image_map.
There was a problem hiding this comment.
I don't think that could happen, as image_map in the runtime is constructed from the image metas which we iterate through during the scan
| @@ -640,9 +640,21 @@ def add_image_meta_change(self, meta: ImageMetadata, rebuild_hint: RebuildHint): | |||
| self.add_assessment_reason(descendant_meta, RebuildHint(RebuildHintCode.ANCESTOR_CHANGING, | |||
| f'Ancestor {meta.distgit_key} is changing')) | |||
|
|
|||
| def is_image_enabled(self, image_name: str) -> bool: | |||
| image_meta = self.runtime.image_map[image_name] | |||
There was a problem hiding this comment.
Would like to add a check to return False if the image_name is not in image_map.
| @@ -640,9 +640,21 @@ def add_image_meta_change(self, meta: ImageMetadata, rebuild_hint: RebuildHint): | |||
| self.add_assessment_reason(descendant_meta, RebuildHint(RebuildHintCode.ANCESTOR_CHANGING, | |||
| f'Ancestor {meta.distgit_key} is changing')) | |||
|
|
|||
| def is_image_enabled(self, image_name: str) -> bool: | |||
| image_meta = self.runtime.image_map[image_name] | |||
There was a problem hiding this comment.
Would like to add a check to return False if the image_name is not in image_map.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vfreex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit a8349c3
into
openshift-eng:main
scan-sources for Konflux is already not scanning for changes in images that are not enabled in the
konfluxconfig stanza.Nonetheless, if a parent image of a disabled one is changing, doozer propagates the child into the report and marks it for rebuild.
To prevent this, perform an extra filtering right before generating the output report, which serves as input to the ocp4-scan-konflux pipeline and to ocp4-konflux.