Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ART-11638 remove art-ci #1223

Merged
merged 1 commit into from
Dec 20, 2024
Merged

ART-11638 remove art-ci #1223

merged 1 commit into from
Dec 20, 2024

Conversation

Ximinhan
Copy link
Contributor

@Ximinhan Ximinhan commented Dec 17, 2024 •
edited
Loading

remove art-ci on cluster

@Ximinhan Ximinhan changed the title ART-11638 fix non yaml file check ART-11638 fix non yaml file check error Dec 19, 2024
Ximinhan
Ximinhan commented Dec 19, 2024
View reviewed changes
ocp-build-data-validator/entrypoint.sh Outdated
# validate changed files and output to result.output
curl -s $pr/files | jq -r .[].filename | xargs validate-ocp-build-data -s $1 2>&1 | tee result.output
# validateonly .yml files in root, rpms/, or images/ directories and output to result.output
curl -s $pr/files | jq -r .[].filename | grep -E '^[^/]+\.yml$|^(rpms|images)/.*\.yml$' | xargs validate-ocp-build-data -s $1 2>&1 | tee result.output
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align with https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.19/.github/workflows/validate.yaml#L8-L10

@Ximinhan Ximinhan closed this Dec 19, 2024
@Ximinhan Ximinhan reopened this Dec 19, 2024
@Ximinhan Ximinhan changed the title ART-11638 fix non yaml file check error ART-11638 remove art-ci Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@Ximinhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 07ee7e4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vfreex
vfreex reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@vfreex vfreex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a286fd7 into openshift-eng:main Dec 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfreex vfreex vfreex left review comments

Assignees

@vfreex vfreex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ximinhan @vfreex