Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-11446: images-health should report only failures #1231

Merged
merged 2 commits into from
Dec 23, 2024
Merged

ART-11446: images-health should report only failures #1231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
152ca3a
ART-11446: images-health should report only failures
mbiarnes Dec 18, 2024
4c6246e
Update doozer/doozerlib/cli/images_health.py
locriandev Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doozer/doozerlib/cli/images_health.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ async def get_concerns(self, image_meta):
elif latest_success_idx > 1:
msg += (f'Last {self.url_text(latest_success_bi_task_url, "success")} '
f'was {latest_success_idx} attempts ago')
elif latest_success_idx == 1:
# Do nothing
return # skipping notifications when only latest attempt failed

# Append the Art-Dash link to the message
msg += f'. {self.url_text(art_dash_link, "Details")}'
Expand Down
Loading