Define metadata.get_latest_konflux_build()

[locriandev]

Follows:

• Define metadata.get_latest_build_async #1266
• Rename medatata.get_latest_build into get_latest_brew_build #1267
• Define common entrypoint for metadata.get_latest_build #1268

Implement the new metadata.get_latest_konflux_build() function and start using it in scan-sources-konflux.
Requires doozer to be called with the --build-system=konflux option.

Test build: https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Focp4-scan-konflux/8122/console

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from locriandev. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thegreyd]

Hmm this behavior might do unexpected things, wondering why change this?

[locriandev]

That is required to mimic the behavior of metadata.get_latest_build. Always defaulting to stream would make this impossible. I've also checked that we always pass in the assembly param when using the konflux_db function directly, so I don't see any risk in here.

[thegreyd]

I'm looking at the code for get_latest_brew_build

art-tools/doozer/doozerlib/metadata.py

Line 412 in de3d8b7

def get_latest_brew_build(self, default: Optional[Any] = -1, assembly: Optional[str] = None, extra_pattern: str = '*',

We have params that are not used in this func, like component_name. Now that it's irrelevant, maybe we have a check that fails if the component name is different from what we determine

[thegreyd]

Same for the el_target, there's a bunch of logic we have to default to something sane. want to suggest we have it here in some way

[locriandev]

component_name is used by get_latest_brew_build to get the package ID, and this is later used to fetch the builds:

builds = koji_api.listBuilds(packageID=package_id,

Overriding it to match something different from the metadata component name could be used in particular cases (e.g. olm bundles?) although I haven't found any occurrences of this. Either way, I feel this and other refactoring changes should be postponed as things are getting messy already and I want to limit changes to what's strictly needed for this task

[openshift-ci]

@locriandev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	0791e26	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.