Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote-assembly: retry on 502 #1274

Merged
merged 1 commit into from
Jan 17, 2025
Merged

promote-assembly: retry on 502 #1274

merged 1 commit into from
Jan 17, 2025

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented Jan 16, 2025

No description provided.

@vfreex
Copy link
Contributor Author

vfreex commented Jan 16, 2025 •
edited
Loading

/hold not tested

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
@vfreex vfreex force-pushed the retry-on-502 branch 2 times, most recently from f877f7f to 6434ab1 Compare January 16, 2025 14:56
@vfreex
Copy link
Contributor Author

vfreex commented Jan 17, 2025

Updated to be less specific about the error.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
vfreex
vfreex commented Jan 17, 2025
View reviewed changes
pyartcd/tests/pipelines/test_promote.py
@@ -1046,13 +1046,11 @@ def test_build_create_symlink(self, _):
dry_run=False
)
pipeline = PromotePipeline(runtime, group="openshift-4.10", assembly="4.10.99", signing_env="prod")
temp_dir = tempfile.mkdtemp()
os.chdir(temp_dir)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.chdir causes issues to other unit test cases. It is not directly related to this PR, but I would like to get it fixed.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@vfreex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 80bde9b link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joepvd
Copy link
Contributor

joepvd commented Jan 17, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 27708d0 into openshift-eng:main Jan 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joepvd joepvd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfreex @joepvd