[Konflux] Support registry auth for bundle build #1281
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vfreex
force-pushed
the
konflux-bundle-auth
branch
from
2a09b21 to
6ada77e
Compare
doozer/doozerlib/util.py
Outdated
| _, out, _ = await exectools.cmd_gather_async(cmd) | ||
| return json.loads(out) | ||
|
|
||
|
|
||
| async def oc_image_info_with_auth_async( |
There was a problem hiding this comment.
it looks like we could just define a single oc_image_info function that accepts optional auth params instead of having oc_image_info_with_auth_async fall back to oc_image_info_async in case username and password are not provided?
There was a problem hiding this comment.
That is possible. I was just lazy to do that. Let me check how easy or hard to change that.
vfreex
force-pushed
the
konflux-bundle-auth
branch
from
6ada77e to
2465ab6
Compare
We have to explicitly pass the registry username and password on buildvm because the buildvm's default auth file is not for quay.io/redhat-user-workloads/ocp-art-tenant/art-images. Also rename `oc_image_info__caching_async` to `oc_image_info_async__caching` for consistency.
vfreex
force-pushed
the
konflux-bundle-auth
branch
from
2465ab6 to
316af39
Compare
|
@vfreex: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We have to explicitly pass the registry username and password on buildvm
because the buildvm's default auth file is not for
quay.io/redhat-user-workloads/ocp-art-tenant/art-images.
Also rename
oc_image_info__caching_asynctooc_image_info_async__cachingfor consistency.