Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doozer olm/bundle: ga-plus explanation #299

Conversation

sosiouxme
Copy link
Contributor

add a comment as to why we're not using ga-plus for now.

@sosiouxme sosiouxme force-pushed the 20240108-ga-plus-disclaimer branch from 5e89a27 to 92e0f3b Compare January 9, 2024 01:23
leave ga-plus functionality, with an explanation for why it's not used.

This reverts commit a83ae10.
@sosiouxme sosiouxme force-pushed the 20240108-ga-plus-disclaimer branch from 92e0f3b to 60f0ee2 Compare January 9, 2024 02:04
@sosiouxme sosiouxme added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 37012a8 into openshift-eng:main Jan 9, 2024
2 checks passed
@sosiouxme sosiouxme deleted the 20240108-ga-plus-disclaimer branch January 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant