Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliott - remove builds cli #312

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Jan 12, 2024

Summary

  • Extract out removing builds flags from find-builds into remove-builds
  • Deprecate remove flags from find-builds
  • This follows our pattern of attach-bugs, remove-bugs and find-bugs being separate; reducing code paths in build sweep and cleaning it up overall, which helps in discovering and fixing issues faster
  • I did not discover this flag being used in any of our pipeline code.

Test

  • ./elliott -g openshift-4.14 --assembly 4.14.9 remove-builds --all --use-default-advisory image --noop
  • NVR that is not attached to advisory - ./elliott -g openshift-4.14 --assembly 4.14.9 remove-builds openshift-enterprise-deployer-container-v4.14.0-202401121302.p0.g286cfa5.assembly.stream --use-default-advisory image --noop
  • NVR that is attached to advisory - ./elliott -g openshift-4.14 --assembly 4.14.9 remove-builds ose-tools-container-v4.14.0-202401100833.p0.g286cfa5.assembly.stream --use-default-advisory image --noop
  • find builds works as usual - ./elliott --group=openshift-4.14 --assembly 4.14.9 find-builds --kind=rpm

@thegreyd thegreyd requested a review from locriandev January 12, 2024 19:06
@thegreyd thegreyd requested a review from joepvd January 12, 2024 19:13
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@locriandev
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@thegreyd
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1ed1efc into openshift-eng:main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants