Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-8472: make in fight not required #316

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Conversation

Ximinhan
Copy link
Contributor

@Ximinhan Ximinhan commented Jan 15, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2024

@Ximinhan: This pull request references ART-8472 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Use release schedule API to get the release date and determine in fight release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2024
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ximinhan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024

@Ximinhan: This pull request references ART-8472 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Use release schedule API to get the release date and determine in fight release

test job:
gen-assembly job: https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/ximhan/job/build%252Fgen-assembly/2/
prepare release job: https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/ximhan/job/build%252Fprepare-release/13/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@thegreyd
Copy link
Contributor

Nice work ximin!
What do you think about getting release date in assembly definition? https://issues.redhat.com/browse/ART-3761
that way we can give an explicit +1 with gen-assembly

@Ximinhan
Copy link
Contributor Author

I think add some log message to slack should have enough awearness

@thegreyd
Copy link
Contributor

looks good with some minor comments 👍

@thegreyd
Copy link
Contributor

/lgtm
/approve

@thegreyd thegreyd merged commit c798dbd into openshift-eng:main Jan 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants