Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[konflux] enable networking-console, nmstate-console #5944

Conversation

ashwindasr
Copy link
Contributor

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Validating 2 file(s)...
Validating images/networking-console-plugin.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 48, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: CGit validation failed for images/networking-console-plugin.yml (https://pkgs.devel.redhat.com/cgit/containers/networking-console-plugin)
Returned error: This validation must run from a network with access to https://pkgs.devel.redhat.com/cgit

@ashwindasr
Copy link
Contributor Author

/cherry-pick openshift-4.18

@openshift-cherrypick-robot

@ashwindasr: once the present PR merges, I will cherry-pick it on top of openshift-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr ashwindasr merged commit 35271bf into openshift-eng:openshift-4.19 Jan 6, 2025
1 of 2 checks passed
@ashwindasr ashwindasr deleted the 4.19-enable-konflux-images branch January 6, 2025 15:29
@openshift-cherrypick-robot

@ashwindasr: new pull request created: #5945

In response to this:

/cherry-pick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr
Copy link
Contributor Author

/cherry-pick openshift-4.17

@openshift-cherrypick-robot

@ashwindasr: new pull request created: #5946

In response to this:

/cherry-pick openshift-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr
Copy link
Contributor Author

/cherry-pick openshift-4.16

@ashwindasr
Copy link
Contributor Author

/cherry-pick openshift-4.15

@openshift-cherrypick-robot

@ashwindasr: new pull request created: #5947

In response to this:

/cherry-pick openshift-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ashwindasr: #5944 failed to apply on top of branch "openshift-4.15":

Applying: scan-sources:noop [konflux] enable networking-console, nmstate-console
Using index info to reconstruct a base tree...
A	images/networking-console-plugin.yml
M	images/nmstate-console-plugin.yml
Falling back to patching base and 3-way merge...
Auto-merging images/nmstate-console-plugin.yml
Auto-merging images/monitoring-plugin.yml
CONFLICT (content): Merge conflict in images/monitoring-plugin.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 scan-sources:noop [konflux] enable networking-console, nmstate-console

In response to this:

/cherry-pick openshift-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants