Add meta-component controller to support bug reassignment. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfojtik
force-pushed
the
meta-controller
branch
from
26269ad to
7d89764
Compare
sttts
reviewed
Sep 21, 2021
| // we only looking for bugs with meta component name inside developer whiteboard | ||
| // and bugs that does not have meta component lead already assigned to them. | ||
| // NOTE: the search result only search for NEW bugs, so ASSIGNED or any other bugs are not present here. | ||
| if !strings.Contains(result[i].DevelWhiteboard, name) || result[i].AssignedTo == component.Lead { |
There was a problem hiding this comment.
so in order to intentionally assign to the (non-meta-)component lead you have to remove the keyword from the whiteboard, right? In other words: you are checking for the state of the bug, not an "assign to lead" event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.