Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] do not build OIDC config unless enabled #1352

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 6, 2024

knative-extensions#4055)

* fix: do not build OIDC config unless enabled



* feat: receiver redeploys verticles when oidc feature changes



* feat: the control plane ensures receiver restarts

When config-features changes, the control plane
sets a annotation on the receiver pods so that
the configmap update is reconciled by k8s



* mvn spotless:apply



* cleanup: goimports



* fix: do not re-deploy verticles



* fix: features config paths are now correct



* fix java unit tests



* mvn spotless:apply



* address review comments



---------

Signed-off-by: Calum Murray <[email protected]>
@openshift-ci openshift-ci bot requested review from aliok and lberk November 6, 2024 11:09
@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 6, 2024

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-reconciler-keda-aws-416 858b0ca link true /test 416-test-reconciler-keda-aws-416
ci/prow/416-test-e2e-aws-416 858b0ca link true /test 416-test-e2e-aws-416
ci/prow/416-test-conformance-aws-416 858b0ca link true /test 416-test-conformance-aws-416
ci/prow/416-test-reconciler-aws-416 858b0ca link true /test 416-test-reconciler-aws-416
ci/prow/416-test-reconciler-encryption-auth-aws-416 858b0ca link true /test 416-test-reconciler-encryption-auth-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@matzew
Copy link
Member Author

matzew commented Nov 7, 2024

/retest

4 similar comments
@matzew
Copy link
Member Author

matzew commented Nov 7, 2024

/retest

@matzew
Copy link
Member Author

matzew commented Nov 7, 2024

/retest

@matzew
Copy link
Member Author

matzew commented Nov 8, 2024

/retest

@matzew
Copy link
Member Author

matzew commented Nov 11, 2024

/retest

@matzew
Copy link
Member Author

matzew commented Nov 13, 2024

/retest-required

1 similar comment
@pierDipi
Copy link
Member

/retest-required

@pierDipi pierDipi merged commit 954d524 into openshift-knative:release-v1.15 Nov 22, 2024
29 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants