Run make generate-release before running konfluxgen #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
requested review from
creydr
and removed request for
aliok and
skonto
This comment was marked as resolved.
This comment was marked as resolved.
We're running `make generate-release` (or equivalent) after running konfluxgen. The issue with that is that the dockerfile generator is also generating the `rpms` lock file which is necessary to enable the prefetch dependencies task for rpms. If we run it before, the RPMs lock file would be present. Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
force-pushed
the
run-make-genecode-before
branch
from
5da93b4 to
d14667e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6086e97
into
openshift-knative:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running
make generate-release(or equivalent) after running konfluxgen. The issue with that is that the dockerfile generator is also generating therpmslock file which is necessary to enable the prefetch dependencies task for rpms.If we run it before, the RPMs lock file would be present.