Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.16] Create test symlinks dynamically #1064

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

matejvasek
Copy link
Collaborator

Some tools dislike having questionable symlinks in git repository so we must create this symlinks dynamically in the test instead of having it committed into the repository.

Some tools dislike having questionable symlinks in git repository so we
must create this symlinks dynamically in the test instead of having it
committed into the repository.

Signed-off-by: Matej Vašek <[email protected]>
@openshift-ci openshift-ci bot requested review from dsimansk and jcrossley3 January 31, 2025 11:31
@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for jcrossley3 January 31, 2025 11:31
@matejvasek
Copy link
Collaborator Author

PTAL @lkingland @gauron99

@matejvasek
Copy link
Collaborator Author

/override "E2E Test (go)"
/override "E2E Test (node)"
/override "E2E Test (python)"
/override "E2E Test (quarkus)"
/override "E2E Test (rust)"
/override "E2E Test (springboot)"
/override "E2E Test (typescript)"
/override "Integration Test (ubuntu-latest)"
/override "Podman Test (ubuntu-latest)"
/override "E2E Test (ubuntu-latest)"

Copy link

openshift-ci bot commented Jan 31, 2025

@matejvasek: Overrode contexts on behalf of matejvasek: E2E Test (go), E2E Test (node), E2E Test (python), E2E Test (quarkus), E2E Test (rust), E2E Test (springboot), E2E Test (typescript), E2E Test (ubuntu-latest), Integration Test (ubuntu-latest), Podman Test (ubuntu-latest)

In response to this:

/override "E2E Test (go)"
/override "E2E Test (node)"
/override "E2E Test (python)"
/override "E2E Test (quarkus)"
/override "E2E Test (rust)"
/override "E2E Test (springboot)"
/override "E2E Test (typescript)"
/override "Integration Test (ubuntu-latest)"
/override "Podman Test (ubuntu-latest)"
/override "E2E Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/test 418-e2e-oncluster-test

@matejvasek
Copy link
Collaborator Author

ptal @gauron99

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek matejvasek merged commit 328b400 into release-v1.16 Jan 31, 2025
42 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants